Use meta["_trade"] for trade %. Not saved to yaml.

Any key starting with _ isn't saved.

dispatchers.cpp

@@ -792,7 +792,7 @@ void TraderDispatch::server_line(const std::string &line,
     BUGZ_LOG(fatal) << "% " << (float)initial_offer / (float)last_offer * 100.0;
     BUGZ_LOG(fatal) << "meta trade setting: " << percent << " for "
                     << active_port << " " << product;
-    director.galaxy.meta["trade"][active_port][product] = percent;
+    director.galaxy.meta["_trade"][active_port][product] = percent;
 
     // subtract total holds value from this port's amount
     auto port = director.galaxy.ports.find(active_port);
@@ -811,8 +811,8 @@ void TraderDispatch::server_line(const std::string &line,
   if (startswith(line, "Agreed, ")) {
     last_offer = 0;
     final_offer = 0;
-    if (director.galaxy.meta["trade"][active_port][product]) {
-      percent = director.galaxy.meta["trade"][active_port][product].as<float>();
+    if (director.galaxy.meta["_trade"][active_port][product]) {
+      percent = director.galaxy.meta["_trade"][active_port][product].as<float>();
       percent += 1.0;
       BUGZ_LOG(fatal) << "Percent for " << active_port << " now " << percent;
     } else {
@@ -852,7 +852,7 @@ void TraderDispatch::server_line(const std::string &line,
     // well rats.
     BUGZ_LOG(fatal) << "We're not interested => meta trade setting: " << percent
                     << " for " << active_port << " " << product;
-    director.galaxy.meta["trade"][active_port][product] = percent;
+    director.galaxy.meta["_trade"][active_port][product] = percent;
     try_again = true;
   }
 

galaxy.cpp

@@ -409,6 +409,12 @@ void Galaxy::save(void) {
     std::string yaml_spacer;
     yaml_spacer.assign(yaml_depth * 2, ' ');
     for (auto const &data : n) {
+      std::string key = data.first.as<std::string>();
+      if (key[0] == '_') {
+        BUGZ_LOG(fatal) << "Skip key: " << key;
+        continue;
+      }
+
       if (data.second.Type() == YAML::NodeType::Scalar) {
         of << yaml_spacer << data.first << ": " << data.second << std::endl;
       } else if (data.second.Type() == YAML::NodeType::Map) {

test-director.cpp

@@ -58,6 +58,7 @@ TEST(director, director_debugging) {
   }
 }
 
+/* // my save rountine handles sequences.  This is a NOP.
 TEST(director, director_galaxy_save) {
   Director dir;
 
@@ -69,6 +70,7 @@ TEST(director, director_galaxy_save) {
 
   EXPECT_TRUE(1) << "No exception, this is good!";
 }
+*/
 
 TEST(director, director_parsing_density) {
   Director dir;
@@ -186,4 +188,4 @@ TEST(director, director_parsing_density) {
   }
 }
 
-} // namespace
+}  // namespace