Display why we stopped moving/trading.

director.cpp

@@ -351,7 +351,7 @@ void Director::proxy_activate(void) {
 
     if (minutes_ago >= 60 ) {
       float hours_ago = minutes_ago / 60.0;
-      std::string message = str(boost::format("Warning: Last Port CIM Refresh was %1$.2f% hours ago.\n\r") % hours_ago);
+      std::string message = str(boost::format("Warning: Last Port CIM Refresh was %1$0.2f hours ago.\n\r") % hours_ago);
       to_client(message);
     }
   } else {

dispatchers.cpp

@@ -581,6 +581,7 @@ void MoveDispatch::server_prompt(const std::string &prompt) {
         // Yes! we found the sector in the scan!
         if (!density_clear(d)) {
           BUGZ_LOG(fatal) << "Failed density check on single move.";
+          why_failed = str(boost::format("Density of %1% at %2%.") % move_to % d.density );  // density of move_to ...
           success = false;
           deactivate();
           return;
@@ -618,6 +619,7 @@ void MoveDispatch::server_prompt(const std::string &prompt) {
         } else {
           to_server("N");
           BUGZ_LOG(fatal) << "density_clear(" << to_check << ") : false";
+          why_failed = str(boost::format("Density of %1% at %2%.") % move_to % d.density );  
           success = false;
           deactivate();
         }
@@ -643,6 +645,7 @@ void MoveDispatch::server_prompt(const std::string &prompt) {
       } else {
         to_server("Y");
         BUGZ_LOG(fatal) << "Stopped by density: " << to_check;
+        why_failed = str(boost::format("Density of %1% at %2%.") % to_check % d.density );  
         success = 0;
         deactivate();
       }
@@ -889,6 +892,7 @@ void TraderDispatch::server_prompt(const std::string &prompt) {
       // Ok, decision time!
       if (director.galaxy.meta["ship"]["holds"]["c"]) {
         // holds contain colonists
+        why_failed = "Holds contain colonists.";
         success = false;
         aborted = true;
         to_client("ScriptTrader FAIL: holds contain colonists.");
@@ -906,6 +910,7 @@ void TraderDispatch::server_prompt(const std::string &prompt) {
           BUGZ_LOG(fatal) << "FAIL: " << total << " total holds, " << empty
                           << " holds empty.";
           to_client("ScriptTrader FAIL: holds are not empty.");
+          why_failed = "Holds are not empty.";
           success = false;
           aborted = true;
           deactivate();
@@ -948,6 +953,7 @@ void TraderDispatch::server_prompt(const std::string &prompt) {
             }
           }
           if (active_port == 0) {
+            why_failed = "No ports will buy what we have in our holds.";
             success = false;
             to_client(
                 "I don't see any ports that are buying what we have in our "

dispatchers.h

@@ -135,6 +135,7 @@ class MoveDispatch : public Dispatch {
   int success;
   int warp_pos;
   bool use_express;
+  std::string why_failed;
   std::string at_destination;
   std::vector<int> warp_lane;
 
@@ -160,7 +161,8 @@ class TraderDispatch : public Dispatch {
 
   // success / failure ?
   bool success;
-
+  std::string why_failed;
+  
   /**
    * internal state
    *

scripts.cpp

@@ -144,7 +144,9 @@ void ScriptTerror::move_notify(void) {
     director.chain->activate();
     return;
   } else {
-    to_client("Move FAILED.\n\r");
+    std::string message = "Move FAILED. " + md->why_failed + "\n\r";
+    // to_client("Move FAILED.\n\r");
+    to_client(message);
     deactivate();
   }
 }
@@ -213,8 +215,11 @@ void ScriptTerror::trade_notify(void) {
     director.chain = move;
     director.chain->activate();
     return;
+  } else {
+    std::string message = "Trade done: " + td->why_failed + "\n\r";
+    to_client(message);
   }
-  to_client("Ok, trade is done.\n\r");
+  // to_client("Ok, trade is done.\n\r");
   deactivate();
 }