Added trade_end_empty. This works with terror.

With this true, we end with empty holds, so no more
issues with "you don't have anything we want".
And port pairs won't care where we start.

scripts.cpp

@@ -32,15 +32,30 @@ void ScriptTrader::activate(void) {
   state = 1;
   percent = 5.0;
   to_server("I");
+  director.galaxy.meta["help"]["stop_percent"] =
+      "ScriptTrader stop trading if below this percent.";
+
   if (director.galaxy.config["stop_percent"]) {
     stop_percent = director.galaxy.config["stop_percent"].as<int>();
-    director.galaxy.meta["help"]["stop_percent"] =
-        "ScriptTrader stop trading if below this percent.";
   } else {
     stop_percent = 20;
     director.galaxy.config["stop_percent"] = stop_percent;
-    director.galaxy.meta["help"]["stop_percent"] =
-        "ScriptTrader stop trading if below this percent.";
+  }
+  director.galaxy.meta["help"]["trade_end_empty"] =
+      "ScriptTrader end trades with empty holds? Y/N";
+
+  if (director.galaxy.config["trade_end_empty"]) {
+    std::string tee =
+        director.galaxy.config["trade_end_empty"].as<std::string>();
+    if ((toupper(tee[0]) == 'Y') || (toupper(tee[0]) == 'T')) {
+      trade_end_empty = true;
+    } else {
+      trade_end_empty = false;
+      // director.galaxy.config["trade_end_empty"] = "N";
+    }
+  } else {
+      trade_end_empty = false;
+      director.galaxy.config["trade_end_empty"] = "N";
   }
 }
 
@@ -293,22 +308,55 @@ void ScriptTrader::server_prompt(const std::string &prompt) {
       }
 
       if (in(prompt, " to buy ")) {
+        bool buy_ok = true;
+
+        if (trade_end_empty) {
+          // Ok, we want to end with empty holds...
+          int other_port;
+          if (active_port == port[0])
+            other_port = port[1];
+          else
+            other_port = port[0];
+
+          // Is target port burnt?
+          auto pos = director.galaxy.ports.find(other_port);
+          bool burnt = false;
+
+          if (pos != director.galaxy.ports.end()) {
+            // We'll find the port.  Really.
+
+            for (int x = 0; x < 3; ++x) {
+              if (trades.foe[x]) {
+                if (pos->second.percent[x] < stop_percent) burnt = true;
+              }
+            }
+          }
+
+          if (burnt) {
+            buy_ok = false;
+          }
+        }
+
         // Ok, what are they selling?
         // char selling = tolower(prompt[18]);
         BUGZ_LOG(fatal) << "Selling: " << selling;
-        for (int x = 0; x < 3; ++x) {
-          if (foe[x] == selling) {
-            // We found the item ... is it something that we're trading?
-            if (trades.foe[x]) {
-              // Yes!
-              to_server("\r");
-              product = x;
-            } else {
-              // No!
-              to_server("0\r");
+        if (!buy_ok) {
+          // no!
+          to_server("0\r");
+        } else
+          for (int x = 0; x < 3; ++x) {
+            if (foe[x] == selling) {
+              // We found the item ... is it something that we're trading?
+              if (trades.foe[x]) {
+                // Yes!
+                to_server("\r");
+                product = x;
+              } else {
+                // No!
+                to_server("0\r");
+              }
             }
           }
-        }
       }
     }
 

scripts.h

@@ -12,6 +12,7 @@ class ScriptTrader : public Dispatch {
   ~ScriptTrader();
 
   char foe[4] = "foe";
+  bool trade_end_empty;
 
   /**
    * internal state

session.cpp

@@ -557,7 +557,7 @@ void Session::client_read(void) {
           }
           client_read();
         } else {
-          BUGZ_LOG(warning) << "CI: read_failed " << ec;
+          BUGZ_LOG(warning) << "C: read_failed " << ec;
           if (connected) {
             BUGZ_LOG(warning) << "Server.shutdown()";
             server_.shutdown(boost::asio::ip::tcp::socket::shutdown_both);