#4 Change to structures rather than needing glom

Закрыто
2 лет назад открыта david · комментариев: 1
David Thielemann прокомментировал 2 лет назад

While my glom is kind of cool, it's also ugly (when I wrote it I was thinking this would be more popularly needed/used, but now that I understand how to deal with nested json and xml structures it's not ugly it's an extra dependency we can do without).

Currently as of 0e62ab3 I introduced a DeviceInfo structure (currently unused), which at least with the code I've seen so far is half the issue with our dependency to glom.

Todo:

  • Form MediaPlayer structure to handle the data we collect from the media-player info query. (See meow-bot's xml parsing out xml attributes)
  • Modify GetQuery to only return []byte received from the query (either device-info or media-player)
  • Implement usage of the new structures and update code to use them.
  • Removal of glom dependency will then be successful.
  • Profit!
While my glom is kind of cool, it's also ugly (when I wrote it I was thinking this would be more popularly needed/used, but now that I understand how to deal with nested json and xml structures it's not ugly it's an extra dependency we can do without). Currently as of 0e62ab3 I introduced a DeviceInfo structure (currently unused), which at least with the code I've seen so far is half the issue with our dependency to glom. Todo: - [x] Form MediaPlayer structure to handle the data we collect from the `media-player` info query. (See meow-bot's xml parsing out xml attributes) - [x] Modify GetQuery to only return []byte received from the query (either `device-info` or `media-player`) - [x] Implement usage of the new structures and update code to use them. - [x] Removal of glom dependency will then be successful. - [x] Profit!
David Thielemann прокомментировал 2 лет назад
Владелец

Closed in [79f2f89bef]

Closed in [79f2f89bef]
Войдите, чтобы присоединиться к обсуждению.
Нет этапа
Нет ответственного
1 участников
Загрузка...
Отмена
Сохранить
Пока нет содержимого.